Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ComplianceSeverity Argument #7852

Merged
merged 4 commits into from
Mar 17, 2019
Merged

Added ComplianceSeverity Argument #7852

merged 4 commits into from
Mar 17, 2019

Conversation

marcotesch
Copy link
Contributor

Signed-off-by: Marco Tesch mtesch@tecracer.de

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Changes proposed in this pull request:

  • Added compliance_severity argument to resource aws_ssm_association

@marcotesch
Added ComplianceSeverity Argument
978a73a 
Signed-off-by: Marco Tesch <mtesch@tecracer.de>
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ssm Issues and PRs that pertain to the ssm service. documentation Introduces or discusses updates to documentation. labels Mar 7, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 15, 2019
@bflad
Copy link
Contributor

bflad commented Mar 15, 2019

Hi @marcotesch 👋 Thanks for contributing this, its looking pretty good so far. Can you please add a new acceptance test in aws/resource_aws_ssm_association_test.go to cover this new functionality?

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Mar 15, 2019
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 15, 2019
@marcotesch
Copy link
Contributor Author

marcotesch commented Mar 15, 2019 •
edited
Loading

Hi @bflad ,

I tried to understand the acceptance test layout as you use it, hope I have done everything right 🙈 .
I added the new Acceptance Test for the functionality. Here is also the output of that test run:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMAssociation_withComplianceSeverity'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSSSMAssociation_withComplianceSeverity -timeout 120m
=== RUN   TestAccAWSSSMAssociation_withComplianceSeverity
=== PAUSE TestAccAWSSSMAssociation_withComplianceSeverity
=== CONT  TestAccAWSSSMAssociation_withComplianceSeverity
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (19.02s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       19.066s

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 15, 2019
@bflad bflad added this to the v2.3.0 milestone Mar 15, 2019
@bflad bflad self-requested a review March 15, 2019 05:45
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Mar 15, 2019
@bflad bflad self-assigned this Mar 15, 2019
@marcotesch
Added Compliance Severity Critical
d1dd62e 
Signed-off-by: Marco Tesch <mtesch@tecracer.de>
@marcotesch
Copy link
Contributor Author

Critical Severity added as well.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 16, 2019
bflad
bflad approved these changes Mar 17, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @marcotesch! 🚀

--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (19.27s)
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (28.60s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (34.14s)
--- PASS: TestAccAWSSSMAssociation_withParameters (36.16s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (36.17s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (36.17s)
--- PASS: TestAccAWSSSMAssociation_withTargets (39.26s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (67.86s)
--- PASS: TestAccAWSSSMAssociation_basic (149.51s)

@bflad bflad merged commit 2b990eb into hashicorp:master Mar 17, 2019
bflad added a commit that referenced this pull request Mar 17, 2019
@bflad
Update CHANGELOG for #7852
77368f6
@marcotesch marcotesch deleted the feature/ssm-association-compliance branch March 17, 2019 07:07
@bflad
Copy link
Contributor

bflad commented Mar 21, 2019

This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@marcotesch @bflad